FFS-2490 Wrap Argyle Data Fetch API's #496
Conversation
…cb3c/FFS-2490-fetch-argyle-data
…m string to floats
…cb3c/FFS-2490-fetch-argyle-data
| @@ -0,0 +1,32 @@ | |||
| module ResponseObjects::FormatMethods::Argyle | |||
There was a problem hiding this comment.
Whew, the module name is a bit of a mouthful, but scoping it here makes the intention clear so it seems good to me.
| # todo: paginate | ||
| json = fetch_identities_api(**params) | ||
| json["results"].map { |identity_json| ResponseObjects::Identity.from_argyle(identity_json) } | ||
| end |
There was a problem hiding this comment.
Hopefully we can rework this when we do the AggregatorDataHelper method so that we're not making the same API call three times in succession.
| @http.build_url(endpoint).to_s | ||
| end | ||
|
|
||
| def store_mock_response(responsePayload:, folderName: "other", fileName:) |
There was a problem hiding this comment.
idiomatic ruby would have these as snake_case. I'm going to follow up with a Rubocop rule to enforce this automatically.
| FileUtils.mkdir_p "spec/support/fixtures/argyle/#{folderName}" | ||
|
|
||
| File.open("spec/support/fixtures/argyle/#{folderName}/#{fileName}.json", "wb") do | ||
| |f| f.puts(JSON.pretty_generate(responsePayload)) |
There was a problem hiding this comment.
Style nitpick - generally the block's argument is on the same line as the do, i.e.
File.open(...) do |f| # <--- |f| goes on this line
f.puts(...)
endI couldn't find a rubocop rule for this.
| }) | ||
| expect(employment).to have_attributes( | ||
| status: "terminated", | ||
| ) |
There was a problem hiding this comment.
There's still some very strange indenting in here. Maybe installing some kind of ruby plugin to do indenting will allow it to autoformat correctly? Rubocop does not seem to have a linter for this one either (not 100% sure, but I tried the obvious ones to no avail).
| store_mock_response( | ||
| folderName: folderName, | ||
| fileName: "request_paystubs", | ||
| responsePayload: fetch_paystubs_api(user: argyle_user_id)) |
There was a problem hiding this comment.
Hmm, maybe at some point we should move these methods into a helper module of some sort so they're not chilling on ArgyleService for the future.
Ticket
Resolves FFS-2490.
Changes
app/spec/support/fixtures/argyle.Context for reviewers
Acceptance testing
:alert: Deploy block! @ffs-eng I just merged PR [#123] and will be doing acceptance testing in demo - please don't deploy until I'm finished!)